From 99ad972395af9953e433b4a7c11bcfd6c4daad3f Mon Sep 17 00:00:00 2001 From: Ben Bridle Date: Fri, 4 Jul 2025 21:17:30 +1200 Subject: Fix sort order of generated symbols file The symbols file was not being generated in ascending address order. This was because the assembler was using unordered HashMaps, which have now been replaced with ordered IndexMaps. --- src/stages/bytecode.rs | 10 +++++----- src/stages/semantic.rs | 6 +++--- src/stages/semantic_tokens.rs | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) (limited to 'src') diff --git a/src/stages/bytecode.rs b/src/stages/bytecode.rs index f0b99df..02cc739 100644 --- a/src/stages/bytecode.rs +++ b/src/stages/bytecode.rs @@ -1,6 +1,6 @@ use crate::*; -use std::collections::HashMap; +use indexmap::IndexMap; /// Doesn't truncate trailing null bytes. @@ -22,8 +22,8 @@ pub fn generate_bytecode(semantic: &Program) -> Result { - definitions: &'a HashMap>, - labels: HashMap, + definitions: &'a IndexMap>, + labels: IndexMap, stack: Vec, bytecode: Vec, errors: Vec>, @@ -35,8 +35,8 @@ struct LabelInformation { } impl<'a> BytecodeGenerator<'a> { - pub fn new(definitions: &'a HashMap>) -> Self { - let mut labels = HashMap::new(); + pub fn new(definitions: &'a IndexMap>) -> Self { + let mut labels = IndexMap::new(); for (name, definition) in definitions { if let DefinitionVariant::LabelDefinition = definition.variant { // Use fake address for now. diff --git a/src/stages/semantic.rs b/src/stages/semantic.rs index f2774a4..909659d 100644 --- a/src/stages/semantic.rs +++ b/src/stages/semantic.rs @@ -1,12 +1,12 @@ use crate::*; -use std::collections::{HashMap, HashSet}; +use indexmap::{IndexMap, IndexSet}; pub fn parse_semantic(syntactic: Vec>) -> Result>> { // Record all label definitions and macro names up front. - let mut definitions = HashMap::new(); - let mut macro_names = HashSet::new(); + let mut definitions = IndexMap::new(); + let mut macro_names = IndexSet::new(); for token in &syntactic { match &token.value { SyntacticToken::LabelDefinition(name) => { diff --git a/src/stages/semantic_tokens.rs b/src/stages/semantic_tokens.rs index fe49c26..fc454be 100644 --- a/src/stages/semantic_tokens.rs +++ b/src/stages/semantic_tokens.rs @@ -1,10 +1,10 @@ use crate::*; -use std::collections::HashMap; +use indexmap::IndexMap; pub struct Program { - pub definitions: HashMap>, + pub definitions: IndexMap>, pub tokens: Vec>, } @@ -69,7 +69,7 @@ fn report_semantic_error(error: &Tracked, source_code: &str) { } -pub fn print_semantic_token(i: usize, token: &SemanticToken, definitions: &HashMap>) { +pub fn print_semantic_token(i: usize, token: &SemanticToken, definitions: &IndexMap>) { match token { SemanticToken::Literal(value) => indent!(i, "Literal({value})"), SemanticToken::Pad(value) => indent!(i, "Pad({value})"), -- cgit v1.2.3-70-g09d2