summaryrefslogtreecommitdiff
path: root/src/generate_html.rs
diff options
context:
space:
mode:
authorBen Bridle <bridle.benjamin@gmail.com>2025-02-11 12:13:40 +1300
committerBen Bridle <bridle.benjamin@gmail.com>2025-02-11 12:14:31 +1300
commit4ce5f34163756f39fefa5114c87922999e9d6320 (patch)
tree6cd99a9d2c116e2db609996dfac57adb5e38a056 /src/generate_html.rs
parent34156a8738eb99d71f69a7334ab2eced52dc7af7 (diff)
downloadtoaster-4ce5f34163756f39fefa5114c87922999e9d6320.zip
URL-encode special characters in unsanitized paths
Unlike for internal links, external links are never sanitized. When an external link contained an apostrophe or a double-quote character, it would prematurely terminate the href property of the containing <a> tag and break the link. Paths in internal and external links are now passed through a new url_encode function, which replaces quote characters with the percent-encoded equivalent.
Diffstat (limited to 'src/generate_html.rs')
-rw-r--r--src/generate_html.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/generate_html.rs b/src/generate_html.rs
index 91424eb..e6bb86f 100644
--- a/src/generate_html.rs
+++ b/src/generate_html.rs
@@ -344,6 +344,7 @@ fn parse_internal_link(name: &str, page: &Page, website: &Website) -> ParsedLink
warn!("Page {from:?} contains link to nonexistent internal heading {heading:?}");
}
}
+ let path = url_encode(&path);
ParsedLink { path, class, label }
}
@@ -375,6 +376,7 @@ fn parse_external_link(label: &str, path: &str, page: &Page, website: &Website)
};
}
}
+ let path = url_encode(&path);
let label = sanitize_text(&label, true);
ParsedLink { path, class: "external", label }
}